Skip to content

Commit 55b292f

Browse files
committed
minor #9046 Use stricter syntax when testing (matt9mg)
This PR was submitted for the 4.0 branch but it was merged into the 2.7 branch instead (closes #9046). Discussion ---------- Use stricter syntax when testing e.g. ```php $mailCollector->getMessageCount(); ``` returns an int so its better to use ```php $this->assertSame($expected, $actual); ```` will also meaning faster testing and better testing within the given example. Commits ------- 3d8ee63 Use stricter syntax when testing
2 parents 1cc68d0 + 3d8ee63 commit 55b292f

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

email/testing.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,17 +45,17 @@ to get information about the messages sent on the previous request::
4545
$mailCollector = $client->getProfile()->getCollector('swiftmailer');
4646

4747
// Check that an email was sent
48-
$this->assertEquals(1, $mailCollector->getMessageCount());
48+
$this->assertSame(1, $mailCollector->getMessageCount());
4949

5050
$collectedMessages = $mailCollector->getMessages();
5151
$message = $collectedMessages[0];
5252

5353
// Asserting email data
5454
$this->assertInstanceOf('Swift_Message', $message);
55-
$this->assertEquals('Hello Email', $message->getSubject());
56-
$this->assertEquals('send@example.com', key($message->getFrom()));
57-
$this->assertEquals('recipient@example.com', key($message->getTo()));
58-
$this->assertEquals(
55+
$this->assertSame('Hello Email', $message->getSubject());
56+
$this->assertSame('send@example.com', key($message->getFrom()));
57+
$this->assertSame('recipient@example.com', key($message->getTo()));
58+
$this->assertSame(
5959
'You should see me from the profiler!',
6060
$message->getBody()
6161
);

0 commit comments

Comments
 (0)