add empty h1 tags to html template #8375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First Example tutorial needs the tag in order to work.
|
I don't understand this proposal. Why is that empty tag needed? |
|
Closing because this doesn't look necessary and we don't have more information. Thanks! |
|
I'm reopening this because it's really needed. I just stumbled upon this issue when trying to solve this problem: symfony/webpack-encore#210 @ArlingtonHouse I'm really sorry that I closed your pull request and I apologize for that! |
javiereguiluz
added
Status: Reviewed
and removed
Status: Needs Review
Waiting feedback
labels
javiereguiluz
approved these changes
Nov 18, 2017
|
I just tweaked the PR to fix the legitimate issue in a different way. |
|
Thank you @ArlingtonHouse! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First Example tutorial needs the tag in order to work.