Skip to content

Commit a3184fd

Browse files
committed
bug #8375 add empty h1 tags to html template (ArlingtonHouse, weaverryan)
This PR was merged into the 3.3 branch. Discussion ---------- add empty h1 tags to html template First Example tutorial needs the tag in order to work. Commits ------- e7642f7 removing h1 but making JS more fool-proof 3a97249 add empty h1 tags to html template
2 parents 54d87af + e7642f7 commit a3184fd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

frontend/encore/simple-example.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ Great! Use ``require()`` to import ``jquery`` and ``greet.js``:
144144
var greet = require('./greet');
145145
146146
$(document).ready(function() {
147-
$('h1').html(greet('john'));
147+
$('body').prepend('<h1>'+greet('john')+'</h1>');
148148
});
149149
150150
That's it! When you build your assets, jQuery and ``greet.js`` will automatically

0 commit comments

Comments
 (0)