Skip to content

Update parameters.rst #8264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Update parameters.rst #8264

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27f6d73
Update parameters.rst
afurculita Aug 8, 2017
65e8f9f
Update parameters.rst
afurculita Aug 9, 2017
a329142
Update parameters.rst
afurculita Aug 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions service_container/parameters.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,9 @@ Constants as Parameters
-----------------------

Setting PHP constants as parameters is also supported.
To take advantage of this feature, map the name of your constant to a parameter
key and define the type as ``constant``.
For the XML format, you need to map the name of your constant to a parameter
key and define the type as ``constant``. For the YAML format, you need to prefix
the name of your constant with ``!php/const:``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this change. I mean the following code blocks already show how to do this. Why should we describe it here again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation now says "To take advantage of this feature, map the name of your constant to a parameter key and define the type as constant". But this is true only for XML format. We need to remove this or to specify that is only for XML format and describe the other ones too. I preferred the second one. The PHP format hasn't been described as it is trivial IMO.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Though I suggest to just remove the second sentence and terminate the previous one with a colon instead.


.. configuration-block::

Expand Down