Update parameters.rst #8264
Update parameters.rst #8264
Conversation
service_container/parameters.rst
Outdated
| key and define the type as ``constant``. | ||
| For the XML format, you need to map the name of your constant to a parameter | ||
| key and define the type as ``constant``. For the YAML format, you need to prefix | ||
| the name of your constant with ``!php/const:``. |
There was a problem hiding this comment.
I am not sure about this change. I mean the following code blocks already show how to do this. Why should we describe it here again?
There was a problem hiding this comment.
The documentation now says "To take advantage of this feature, map the name of your constant to a parameter key and define the type as constant". But this is true only for XML format. We need to remove this or to specify that is only for XML format and describe the other ones too. I preferred the second one. The PHP format hasn't been described as it is trivial IMO.
There was a problem hiding this comment.
You're right. Though I suggest to just remove the second sentence and terminate the previous one with a colon instead.
service_container/parameters.rst
Outdated
| To take advantage of this feature, map the name of your constant to a parameter | ||
| key and define the type as ``constant``. | ||
| For the XML format, you need to map the name of your constant to a parameter | ||
| key and define the type as ``constant``: |
There was a problem hiding this comment.
Sorry, if that wasn't clear enough. I would replace the whole paragraph (line 245 to 247) with this:
Setting PHP constants as parameters is also supported:
|
Thank you @afurculita. |
Setting php constants as parameters is different for each configuration format.