Skip to content

[Router] Fix custom router loader service declaration #7978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2017
Merged

[Router] Fix custom router loader service declaration #7978

merged 1 commit into from
Jun 8, 2017

Conversation

michaelperrin
Copy link
Contributor

The service tag was not declared correctly.

@xabbuh
Copy link
Member

xabbuh commented Jun 2, 2017

Did you try this? Symfony 3.3 should support this notation IIRC.

@michaelperrin
Copy link
Contributor Author

@xabbuh I did try this (I can give you the link to the repo if needed). And it doesn't work on Symfony 3.3.

What Symfony 3.3 introduced is a short syntax to define arguments (see here).
In the current docs, it doesn't work as routing.loader is passed as if it were an argument, instead of a tag.

GuilhemN
GuilhemN approved these changes Jun 8, 2017
View reviewed changes
Copy link
Contributor

@GuilhemN GuilhemN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was indeed wrong, good catch 👍

@GuilhemN GuilhemN mentioned this pull request Jun 8, 2017
Merged
xabbuh
xabbuh approved these changes Jun 8, 2017
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked this with @GuilhemN and this is indeed the right fix

@xabbuh
Copy link
Member

xabbuh commented Jun 8, 2017

Good catch, thanks @michaelperrin.

@xabbuh xabbuh merged commit ae958b8 into symfony:3.3 Jun 8, 2017
xabbuh added a commit that referenced this pull request Jun 8, 2017
@xabbuh
minor #7978 [Router] Fix custom router loader service declaration (mi…
75875ff 
…chaelperrin)

This PR was merged into the 3.3 branch.

Discussion
----------

[Router] Fix custom router loader service declaration

The service tag was not declared correctly.

Commits
-------

ae958b8 Fix custom router loader service declaration
@michaelperrin michaelperrin deleted the fix/custom-route-loader branch June 8, 2017 20:29
xabbuh added a commit that referenced this pull request Jun 9, 2017
@xabbuh
minor #8007 Revert a wrong change from #7877 (GuilhemN)
a8b227e 
This PR was merged into the 3.3 branch.

Discussion
----------

Revert a wrong change from #7877

As spotted by #7978, the short service syntax is about arguments and not tags, so this change was wrong.

Commits
-------

f3b1112 Revert a wrong change from #7877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@GuilhemN GuilhemN GuilhemN approved these changes

Assignees
No one assigned
Labels
Routing Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelperrin @xabbuh @GuilhemN @carsonbot