Skip to content

How to change the 'time' parameter of the deduplication handler #7896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 3, 2017
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions logging/monolog_email.rst
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ it is broken down.
handler: deduplicated
deduplicated:
type: deduplication
# uncomment this line for values other than 60 seconds:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment and the provided time: 10 example looks a bit confusing to me. What if we explain this option more in detail and don't include the time: 10 example commented?

deduplicated:
    type:    deduplication
    # the time in seconds during which duplicate entries are discarded (default: 60)
    time: 10
    handler: swift

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like @javiereguiluz suggestion.

# time: 10
handler: swift
swift:
type: swift_mailer
Expand Down Expand Up @@ -64,6 +66,14 @@ it is broken down.
action-level="critical"
handler="deduplicated"
/>
<!--
use the time attribute for values other than the default
of 60 seconds:
<monolog:handler name="deduplicated"
type="deduplicated"
time="10"
handler="swift" />
-->
<monolog:handler
name="deduplicated"
type="deduplication"
Expand Down Expand Up @@ -108,6 +118,8 @@ it is broken down.
),
'deduplicated' => array(
'type' => 'deduplication',
// uncomment this line for values other than 60 seconds:
// 'time' => 10,
'handler' => 'swift',
),
'swift' => array(
Expand Down