-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
How to change the 'time' parameter of the deduplication handler #7896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Don't know how this needs to be written in XML & PHP, sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed an example for the XML and PHP format.
logging/monolog_email.rst
Outdated
@@ -28,6 +28,8 @@ it is broken down. | |||
handler: deduplicated | |||
deduplicated: | |||
type: deduplication | |||
# uncomment this line for values other than 60 seconds: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment and the provided time: 10
example looks a bit confusing to me. What if we explain this option more in detail and don't include the time: 10
example commented?
deduplicated:
type: deduplication
# the time in seconds during which duplicate entries are discarded (default: 60)
time: 10
handler: swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like @javiereguiluz suggestion.
@javiereguiluz Don't know what you mean exactly. My motivation for committing this: Right now, the
So I figured I could squeeze it right into the first code block. Not ideal, but better than nothing :-) However, we could certainly create a separate code block for this, maybe something like:
|
As suggested by symfony#7896 (review) XML and PHP syntax is taken from https://github.com/symfony/symfony-docs/pull/7896/files/9d2f2fd9df136b63275e0ce991196e9dda213f7d
Removing the now obsolete comments of https://github.com/symfony/symfony-docs/pull/7896/files/9d2f2fd9df136b63275e0ce991196e9dda213f7d
…andler (ThomasLandauer, xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- How to change the 'time' parameter of the deduplication handler Don't know how this needs to be written in XML & PHP, sorry. Commits ------- 4b7bc67 Update monolog_email.rst da281f2 `time` option 9d2f2fd add XML and PHP config examples 25e0bc1 How to change the 'time' parameter of the deduplication handler
Don't know how this needs to be written in XML & PHP, sorry.