Skip to content

Minor reword to improve readability #7838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Minor reword to improve readability #7838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion introduction/from_flat_php_to_symfony2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ on the requested URI::
echo '<html><body><h1>Page Not Found</h1></body></html>';
}

For organization, both controllers (formerly ``index.php`` and ``show.php``)
For organization, both controllers (formerly ``/index.php`` and ``/index.php/show``)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not consistent with the filename above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that the article talks about the controllers related to the list_action() and show_action() functions. Given that this controllers don't have a name, or a function or anything to refer to, I prefer to mention the original URI of each controller (/index.php and /index.php/show) to avoid issues like the original bug report. Otherwise, how can we solve this? Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you, so the filename above should be changed accordingly, that's what I meant :).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but I don't follow you. This is what I'm trying to do:

controller-names

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems I got confused by this line https://github.com/symfony/symfony-docs/pull/7838/files#diff-9bc9c246d5d01be55bf80517de478b73R333, but I understand now it does not need to be changed 😅

are now PHP functions and each has been moved into a separate file named ``controllers.php``::

// controllers.php
Expand Down