-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Minor reword to improve readability #7838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -370,7 +370,7 @@ on the requested URI:: | |||
echo '<html><body><h1>Page Not Found</h1></body></html>'; | |||
} | |||
|
|||
For organization, both controllers (formerly ``index.php`` and ``show.php``) | |||
For organization, both controllers (formerly ``/index.php`` and ``/index.php/show``) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not consistent with the filename above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that the article talks about the controllers related to the list_action() and show_action() functions. Given that this controllers don't have a name, or a function or anything to refer to, I prefer to mention the original URI of each controller (/index.php and /index.php/show) to avoid issues like the original bug report. Otherwise, how can we solve this? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you, so the filename above should be changed accordingly, that's what I meant :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems I got confused by this line https://github.com/symfony/symfony-docs/pull/7838/files#diff-9bc9c246d5d01be55bf80517de478b73R333, but I understand now it does not need to be changed 😅
@@ -370,7 +370,7 @@ on the requested URI:: | |||
echo '<html><body><h1>Page Not Found</h1></body></html>'; | |||
} | |||
|
|||
For organization, both controllers (formerly ``index.php`` and ``show.php``) | |||
For organization, both controllers (formerly ``/index.php`` and ``/index.php/show``) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems I got confused by this line https://github.com/symfony/symfony-docs/pull/7838/files#diff-9bc9c246d5d01be55bf80517de478b73R333, but I understand now it does not need to be changed 😅
Thank you @javiereguiluz. |
This fixes #7202.