Change '.xliff' extensions to '.xlf' #5190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@xelaris Sorry I overlooked that before, but could you please also update the docs of the Translation component? |
|
@xabbuh The doc of the component is updated now. |
|
👍 |
|
I agree with you Alexander. Thanks for fixing it |
wouterj
added a commit
that referenced
this pull request
Apr 26, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Change '.xliff' extensions to '.xlf' | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | I'm not committed to this PR, since I prefer `.xliff` over `.xlf` extension personally, but when calling `app/console translation:update --output-format xlf en --force` you get a `app/Resources/translations/messages.en.xlf` file and this is especially bad if you already have an equivalent `.xliff` file. In addition `.xlf` is the default extension for distributed translations since symfony/symfony@2cb6260 and `XliffFileDumper` uses the `xlf` extension. So I think it is more consistent to show `.xlf` files in the doc. Commits ------- 4ce1a94 Change 'xliff' extensions and loader name to 'xlf'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not committed to this PR, since I prefer
.xliffover.xlfextension personally, but when callingapp/console translation:update --output-format xlf en --forceyou get aapp/Resources/translations/messages.en.xlffile and this is especially bad if you already have an equivalent.xlifffile. In addition.xlfis the default extension for distributed translations since symfony/symfony@2cb6260 andXliffFileDumperuses thexlfextension. So I think it is more consistent to show.xlffiles in the doc.