Skip to content

Reworded the note about Windows console and output coloring #5031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2015

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? yes
New docs? no
Applies to 2.3+
Fixed tickets -

Two changes:

  • The note about "Windows + Console colors" is moved to the section that explains console colors.
  • The note itself is reworded to be a bit more friendly.

@wouterj
Copy link
Member

wouterj commented Feb 20, 2015

👍

@@ -124,6 +115,14 @@ This prints::
Coloring the Output
~~~~~~~~~~~~~~~~~~~

.. note::

By default, Windows command console doesn't support output coloring. The
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "the Windows command console"?

By default, the Windows command console doesn't support output coloring. The
Console component disables output coloring for Windows systems, but if your
commands invoke other scripts which emit color sequences, they will be
wrongly displayed as raw escape characters. Install the free `ANSICON`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they will display as raw escaped characters.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look grammatically correct to me:

they will display as raw escaped characters.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note should mention both ANSICON and ConEmu.

ConEmu might be a better solution btw, because ANSICON is flagged as malware by several antivirus tools because of the way it works (it intercepts the CMD buffer). ConEmu does not suffer from this, because it is a terminal on its own (embedding any shell in it, be it CMD, Powershell, GitBash, etc...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your comment. I've added ConEmu as the first recommended application.

@weaverryan
Copy link
Member

This reads really nicely. Thanks Javier!

@weaverryan weaverryan merged commit ec85112 into symfony:2.3 Mar 14, 2015
weaverryan added a commit that referenced this pull request Mar 14, 2015
…ng (javiereguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Reworded the note about Windows console and output coloring

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets | -

Two changes:

  * The note about *"Windows + Console colors"* is moved to the section that explains console colors.
  * The note itself is reworded to be a bit more friendly.

Commits
-------

ec85112 Suggested ConEmu in addition to ANSICON to solve the Windows coloring limitation
71f30a2 Minor rewording
59624f6 Reworded the note about Windows console and output coloring
@javiereguiluz javiereguiluz deleted the reword_console_colors_note branch January 3, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants