Skip to content

Improved sentence #4976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Improved sentence #4976

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
761f90a
Readability
edsonmedina Feb 8, 2015
24ec5e6
Update configuration.rst
edsonmedina Mar 8, 2015
e99b4a4
Update configuration.rst
edsonmedina Mar 8, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion best_practices/configuration.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ to control the number of posts to display on the blog homepage:
parameters:
homepage.num_items: 10

If you ask yourself when the last time was that you changed the value of
If you ask yourself when was the last time you changed the value of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I don't love the new one either. The problem is the sentence is almost a question, but not really a question, so it's funny both ways. So how about something totally different:

If you've done something like this in the past, it's likely that you've in fact *never* actually needed
to change that value.

What do you think @edsonmedina?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

*any* option like this, odds are that you *never* have. Creating a configuration
option for a value that you are never going to configure just isn't necessary.
Our recommendation is to define these values as constants in your application.
Expand Down