Improved sentence #4976
Closed
Improved sentence #4976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -101,7 +101,7 @@ to control the number of posts to display on the blog homepage: | |||
| parameters: | |||
| homepage.num_items: 10 | |||
|
|
|||
| If you ask yourself when the last time was that you changed the value of | |||
| If you ask yourself when was the last time you changed the value of | |||
There was a problem hiding this comment.
Ah, I don't love the new one either. The problem is the sentence is almost a question, but not really a question, so it's funny both ways. So how about something totally different:
If you've done something like this in the past, it's likely that you've in fact *never* actually needed
to change that value.What do you think @edsonmedina?
|
@edsonmedina Could you please make the suggested changes? :) |
|
Done @xabbuh |
|
@edsonmedina If you now could please change the line wrapping to wrap them after the first word that crosses the 72nd character, your pull request will be perfect. :) |
|
@xabbuh check it now |
|
It's perfect now. Thanks @edsonmedina! |
|
👍 |
|
Thanks Edson for the PR and working with us with the updates. It's very nice now! |
weaverryan
added a commit
that referenced
this pull request
Mar 13, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.