Skip to content

Removed the redundant usage of layer. #4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Removed the redundant usage of layer. #4375

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e49651
Removed the redundant usage of layer.
Oct 25, 2014
5db6922
Shorten the = to match the length of the text.
Oct 25, 2014
0878bca
Removed the possession from Doctrine.
Oct 26, 2014
585d9d5
One more again. I could have sworn I had them lined up.
Oct 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cookbook/doctrine/dbal.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
.. index::
pair: Doctrine; DBAL

How to Use Doctrine's DBAL Layer
How to Use Doctrine's DBAL
================================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please shorten the underline to match the length of the headline?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and it should be "Doctrine DBAL" now

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wouterj I can make the change, but I'm curious if you can explain your line of thinking a bit more so I can understand what you are looking for.

The reason I'm leaving Doctrine as possessive of the DBAL is that in the document, it is explained that the ORM component of Doctrine is a higher level of the DBAL. So Doctrine owns multiple components, making it possessive of the DBAL. That's my reasoning at least.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course :)

The database abstraction layer created by Doctrine is called "Doctrine DBAL", just like the object relation mapper is called "Doctrine ORM". While it's also the DBAL of the Doctrine Project, it's official name is "Doctrine DBAL". That's why I want to use "Doctrine DBAL" instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Changing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wouterj Changed.


.. note::

This article is about Doctrine DBAL's layer. Typically, you'll work with
This article is about the Doctrine DBAL. Typically, you'll work with
the higher level Doctrine ORM layer, which simply uses the DBAL behind
the scenes to actually communicate with the database. To read more about
the Doctrine ORM, see ":doc:`/book/doctrine`".
Expand Down