Removed the redundant usage of layer. #4375
Conversation
Since DBAL is database abstraction layer, and is defined in the document as such, to me it reads funny to have it as database abstraction layer layer. It sounds nitpicky, I know, but I find it an easier read this way. Also, the possessive DBAL stuck out ("DBAL's layer") as the DBAL doesn't own a layer, it is the layer.
| @@ -1,12 +1,12 @@ | |||
| .. index:: | |||
| pair: Doctrine; DBAL | |||
|
|
|||
| How to Use Doctrine's DBAL Layer | |||
| How to Use Doctrine's DBAL | |||
| ================================ | |||
There was a problem hiding this comment.
Can you please shorten the underline to match the length of the headline?
There was a problem hiding this comment.
and it should be "Doctrine DBAL" now
There was a problem hiding this comment.
@wouterj I can make the change, but I'm curious if you can explain your line of thinking a bit more so I can understand what you are looking for.
The reason I'm leaving Doctrine as possessive of the DBAL is that in the document, it is explained that the ORM component of Doctrine is a higher level of the DBAL. So Doctrine owns multiple components, making it possessive of the DBAL. That's my reasoning at least.
There was a problem hiding this comment.
Of course :)
The database abstraction layer created by Doctrine is called "Doctrine DBAL", just like the object relation mapper is called "Doctrine ORM". While it's also the DBAL of the Doctrine Project, it's official name is "Doctrine DBAL". That's why I want to use "Doctrine DBAL" instead.
|
@micheal These are only little details, but they matter as well. 👍 |
|
@xabbuh Done. :) |
|
Thanks! |
| How to Use Doctrine's DBAL Layer | ||
| ================================ | ||
| How to Use Doctrine DBAL | ||
| ========================== |
There was a problem hiding this comment.
We need to remove 2 == so that it has the same length as the title. Yep, this actually matters :).
There was a problem hiding this comment.
Fixed, I hope. I could have sworn I had things fixed properly already.
|
Great, thanks so much @micheal! |
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes #4375). Discussion ---------- Removed the redundant usage of layer. Since DBAL is database abstraction layer, and is defined in the document as such, to me it reads funny to have it as database abstraction layer layer. It sounds nitpicky, I know, but I find it an easier read this way. Also, the possessive DBAL stuck out ("DBAL's layer") as the DBAL doesn't own a layer, it is the layer whereas Doctrine does own the layer and is properly defined in the header. Commits ------- 27339c7 One more again. I could have sworn I had them lined up. 84164fa Removed the possession from Doctrine. 693698e Shorten the = to match the length of the text. 5ea2902 Removed the redundant usage of layer.
Since DBAL is database abstraction layer, and is defined in the document as such, to me it reads funny to have it as database abstraction layer layer. It sounds nitpicky, I know, but I find it an easier read this way. Also, the possessive DBAL stuck out ("DBAL's layer") as the DBAL doesn't own a layer, it is the layer whereas Doctrine does own the layer and is properly defined in the header.