getRequest() is deprecated in version 2.4 #3387
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed $this->getRequest() and added it as a parameter to be passed to loginAction() method
|
This has recently been fixed in #3330. |
|
Unfortunately, someone already fixed this on the 2.3 branch (as pointed out by @xabbuh). That branch will soon be merged into the 2.4 branch, so the 2.4 branch will soon have this fix too. I hope we get more PRs from you, as it's always sad if we can't merge a good PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed $this->getRequest() and added it as a parameter to be passed to loginAction() method