Removed all occurences of $this->getRequest() #3330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The request is a data object, and so the request should not be inside the container. That's why the request will be removed from the container in Symfony 3.0 So it is better to let the HttpKernel injects the request when the user want to use the request. More over, it is faster. The HttpKernel will always check if the request should be injected. So injecting the request is time constant. However, retrieve the request from the container will execute more calls.
|
👍 |
weaverryan
added a commit
that referenced
this pull request
Dec 26, 2013
Removed all occurences of $this->getRequest()
weaverryan
added a commit
that referenced
this pull request
Dec 26, 2013
|
Great work Grégoire! And nice chatting with you at the conference - see you next year ;) |
|
Thank you for your amazing work ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
The request is a data object, and so the request should not be
inside the container. That's why the request will be removed
from the container in Symfony 3.0
So it is better to let the HttpKernel injects the request when
the user want to use the request.
More over, it is faster. The HttpKernel will always check if the
request should be injected. So injecting the request is time constant.
However, retrieve the request from the container will execute more
calls.