Skip to content

[Contributing][Patches] Fix the broken tip about coding standards #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2013
Merged

[Contributing][Patches] Fix the broken tip about coding standards #3329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions contributing/code/patches.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,14 +177,12 @@ in mind the following:

.. tip::

You can check the coding standards of your patch by running the following
`script <http://cs.sensiolabs.org/get/php-cs-fixer.phar>`_
(`source <https://github.com/fabpot/PHP-CS-Fixer>`_):
When submitting pull requests, `ubot`_ checks your code
for common typos and verifies that you are using the PHP coding standards
as defined in PSR-1 and PSR-2.

.. code-block:: bash

$ cd /path/to/symfony/src
$ php symfony-cs-fixer.phar fix . Symfony20Finder
Whenever it detects problems, it kindly posts a comment on your pull request
with a patch.

.. tip::

Expand Down Expand Up @@ -410,3 +408,4 @@ of all the commits. When you finish, execute the push command.
.. _`travis-ci.org status icon`: http://about.travis-ci.org/docs/user/status-images/
.. _`travis-ci.org Getting Started Guide`: http://about.travis-ci.org/docs/user/getting-started/
.. _`documentation repository`: https://github.com/symfony/symfony-docs
.. _ubot: http://ubot.io