Skip to content

[Contributing][Patches] Fix the broken tip about coding standards #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dcsg
Copy link
Member

@dcsg dcsg commented Dec 14, 2013

Q A
Doc fix? yes
New docs? no
Applies to 2.3+
Fixed tickets none


$ cd /path/to/symfony/src
$ php symfony-cs-fixer.phar fix . Symfony20Finder
Whenever he detects problems, he kindly post a comment on your pull request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ubot is a he? it should be an it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be honest I didn't realize that because I basically copied part of the information from the ubot website.

@dcsg
Copy link
Member Author

dcsg commented Dec 15, 2013

@wouterj thanks, completely forgotten that it wasn't Markdown files ;)

@cordoval already replaced he with it


$ cd /path/to/symfony/src
$ php symfony-cs-fixer.phar fix . Symfony20Finder
Whenever it detects problems, it kindly post a comment on your pull request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

posts

weaverryan added a commit that referenced this pull request Dec 26, 2013
…bot_in_pacthes

[Contributing][Patches] Fix the broken tip about coding standards
@weaverryan weaverryan merged commit f4c41c4 into symfony:2.3 Dec 26, 2013
@weaverryan
Copy link
Member

Thanks Daniel! I've tweaked a few things at sha: eb2c184 since ubot's name and how it works have changed. If any details are wrong (or change in the future), let us know!

Cheers!

@dcsg
Copy link
Member Author

dcsg commented Dec 26, 2013

Thanks @weaverryan, didn't notice that!

@dcsg dcsg deleted the replace_broken_tip_with_ubot_in_pacthes branch December 26, 2013 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants