Skip to content

Mini fixes #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 18, 2013
Merged

Mini fixes #3251

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8dbbbc8
Fix formatting
bicpi Nov 30, 2013
bcf3633
Remove confusing sample code
bicpi Nov 30, 2013
883402c
Improve fixes
bicpi Dec 2, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions cookbook/form/form_customization.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,9 +666,6 @@ You can also override the markup for an entire field row using the same method:

.. code-block:: html+jinja

{# _product_name_row.html.twig #}
{% form_theme form _self %}

{% block _product_name_row %}
<div class="name_row">
{{ form_label(form) }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this - I believe the {% form_theme form _self %} is needed for this. But I agree that the filename is wrong - this could be any file and it is confusing. This may have been copied from the PHP example below it. So, I believe we should only remove line 669.

Expand Down
4 changes: 2 additions & 2 deletions cookbook/logging/monolog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ The basic handler is the ``StreamHandler`` which writes logs in a stream
Monolog comes also with a powerful built-in handler for the logging in
prod environment: ``FingersCrossedHandler``. It allows you to store the
messages in a buffer and to log them only if a message reaches the
action level (ERROR in the configuration provided in the standard
edition) by forwarding the messages to another handler.
action level (``error`` in the configuration provided in the Standard
Edition) by forwarding the messages to another handler.

Using several handlers
~~~~~~~~~~~~~~~~~~~~~~
Expand Down