Skip to content

Mini fixes #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 18, 2013
Merged

Mini fixes #3251

merged 3 commits into from
Dec 18, 2013

Conversation

bicpi
Copy link
Contributor

@bicpi bicpi commented Nov 30, 2013

Q A
Doc fix? yes
New docs? no
Applies to 2.2+
Fixed tickets -

form_customization
Preceding code lines are not related to what the code demonstrates: Twig blocks do not need to be defined in separate files; the file does not hold a form, so importing a theme is confusing

monolog
Standard Edition uses lowercase error value in config_prod.yml

@@ -666,9 +666,6 @@ You can also override the markup for an entire field row using the same method:

.. code-block:: html+jinja

{# _product_name_row.html.twig #}
{% form_theme form _self %}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this - I believe the {% form_theme form _self %} is needed for this. But I agree that the filename is wrong - this could be any file and it is confusing. This may have been copied from the PHP example below it. So, I believe we should only remove line 669.

@bicpi
Copy link
Contributor Author

bicpi commented Dec 2, 2013

@weaverryan I've added the "self" theming again, but also made it consistent with the preceding example, i.e. the axample outputs the form row at the end- as shown with the form widget before. The PHP example show both, the main template echoing the form row and the single PHP file that defines the row "block" - as shown in the wifget example before.

Along the way I've also fixes four lines with wrong PHP code that was mixed with Twig syntax.

weaverryan added a commit that referenced this pull request Dec 18, 2013
@weaverryan weaverryan merged commit ee25fc6 into symfony:2.2 Dec 18, 2013
@weaverryan
Copy link
Member

Yep, big 👍 for this - very careful work Philipp :).

Thanks!

@bicpi bicpi deleted the mini_fixes branch January 5, 2014 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants