Skip to content

Rewrite validation groups explanation. #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2013
Merged

Rewrite validation groups explanation. #2762

merged 1 commit into from
Jul 20, 2013

Conversation

dsuurlant
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to all (or 2.1+)
Fixed tickets #2750

@bamarni
Copy link
Contributor

bamarni commented Jun 26, 2013

I'm also confused about this section, why not removing User instead of Defaut though? From what I understand the class name is just another way to reference the Default group when using group sequences, as stated a few lines below :

Group sequences cannot contain the group Default, as this would create a loop. Instead, use the group {ClassName} (e.g. User) instead.

@dsuurlant
Copy link
Contributor Author

I removed Default because it is not actually used as a group reference in the code. It exists on a logical level, but when you want to refer to it in Group Sequence, you use the entity's class name. Thus, listing 'Default' as one of the validation groups would be the most confusing.

weaverryan added a commit that referenced this pull request Jul 20, 2013
Rewrite validation groups explanation.
@weaverryan weaverryan merged commit d32296d into symfony:2.1 Jul 20, 2013
@weaverryan
Copy link
Member

Hi guys!

I think this is a nice clarification - @DanielleSuurlant I think mentioning just the 2 groups as you've done here is the best idea.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants