[Process] Add documentation about signal and getPid methods

[romainneutron]

Documentation for PR symfony/symfony#5476

[wouterj]

// ... do other things

[romainneutron]

Hey @wouterj , thanks for the review ! I'll fix this now. Just a question : what does WCM stands for ?

[romainneutron]

@wouterj I've addressed what you mentioned.

Btw, the rest of the process component docs is not compatible with what you suggested, should I open another PR to fix this ? If yes, on which branch should I do it ?

[wouterj]

Just a question : what does WCM stands for ?

Waiting Code Merge. It means that this documentation should not get merged until the code is merged into the framework.

Btw, the rest of the process component docs is not compatible with what you suggested, should I open another PR to fix this ? If yes, on which branch should I do it ?

Can you please say which of my comments? I think I'll have to learn you some on-the-edge-sphinx :)

[romainneutron]

:) I'm always happy to learn things !

Can you please say which of my comments? I think I'll have to learn you some on-the-edge-sphinx :)

see https://raw.github.com/symfony/symfony-docs/master/components/process.rst, none of the php blocks are prefixed with .. code-block:: php.
Your comment about replacing // do other things by // ... do other things can also be applied on current master

[romainneutron]

btw, the PR is merged

[stof]

the PHP bug number shoud be a link to the PHP issue tracker

[stof]

ok, all you need is adding _ to make it a link. The reference is already at the end of the file

[romainneutron]

fixed ! by the way, there was a typo in the bug number that I also fixed :)

[wouterj]

see https://raw.github.com/symfony/symfony-docs/master/components/process.rst, none of the php blocks are prefixed with .. code-block:: php.

I'll take an example:

The :class:`Symfony\\Component\\Process\\Process` class allows you to execute
a command in a sub-process::

    use Symfony\Component\Process\Process;

    $process = new Process('ls -lsa');
    $process->run();

Do you notice the double colon at the end of the sentence before the code block? That indicates the following indented text is PHP code. Sphinx will then replace the double colon with one. So, after parsing this is rendered the same as:

The :class:`Symfony\\Component\\Process\\Process` class allows you to execute
a command in a sub-process:

.. code-block:: php

    use Symfony\Component\Process\Process;

    $process = new Process('ls -lsa');
    $process->run();

The :: is a shortcut when you already use a colon at the end of the sentence. In those cases, we prefer to use it. When your sentence doesn't end with a colon (as in this PR) you still need to use the code-block alternative.

[romainneutron]

Great ! I now understand ! Thank you very much for this detailled explanation

[romainneutron]

PR title updated, code has been merged

[weaverryan]

Hi Romain!

I've merged this in with only minor tweaks. I also backported the "stop" method to 2.1 (without the signal argument) - it was something we were missing in the earlier version.

Thanks!

[romainneutron]

I just read your tweaks, wonderful ! bravo !