[VarExporter] Remove "lazyObjectId" from LazyGhostTrait because it doesn't seem to do anything #19722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove "lazyObjectId" from LazyGhostTrait because it doesn't seem to do anything
|
friendly ping @alexandre-daubois as you contributed this in #17785 |
|
This was a requirement in the early days of lazy ghosts implementation, and I think it is indeed not necessary anymore. The README of VarExporter doesn't mention it. I think it is safe to remove 😊 |
xabbuh
approved these changes
Mar 29, 2024
|
Good catch Mickael! Thanks and congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
If I didn't miss any hidden dynamic resolving black magic, the variable "lazyObjectId" doesn't seem to have any uses for LazyGhost to work, if that's the case, I made the modification to remove this potentially missleading part of the documentation