[VarExporter] Add LazyGhostTrait and LazyProxyTrait documentation
#17785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
lazy-ghost-proxies
branch
from
48591c7 to
00e2a9f
Compare
alexandre-daubois
force-pushed
the
lazy-ghost-proxies
branch
from
00e2a9f to
722f4d3
Compare
alexandre-daubois
force-pushed
the
lazy-ghost-proxies
branch
from
722f4d3 to
74df2d0
Compare
|
@nicolas-grekas if you find some time for this, please help us review this. You are the only one who can do it 🙌 Thanks a lot! |
javiereguiluz
force-pushed
the
lazy-ghost-proxies
branch
from
74df2d0 to
ae0f85f
Compare
|
Thank you Alex! I've merged this so readers can access to this information to review it, so they can report issues or possible improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Friendly ping @nicolas-grekas for your review on this technical one. I based myself a lot on the README of VarExporter that was filled-in (thanks for this, that was some priceless help here!) and your SymfonyCon talk.
About your comment #17784 (review), it seems that occurrences of ProxyManager have already been removed for 6.2 and above. 🙂
Fixes #16970
Fixes #17249