Skip to content

[Attributes] Add attributes overview for 6.3 #18015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Mar 7, 2023

Followup of #18003 and and waiting merge of #18014

Again, I'm keeping an eye on upmerge and will rebase accordingly 🙂

@carsonbot carsonbot added this to the 6.3 milestone Mar 7, 2023
@OskarStark
Copy link
Contributor

Upmerge done ✅

@alexandre-daubois alexandre-daubois force-pushed the attributes-overview-6.3 branch 2 times, most recently from e6e6287 to 2367b09 Compare March 9, 2023 09:10
@alexandre-daubois alexandre-daubois force-pushed the attributes-overview-6.3 branch 5 times, most recently from d84b63d to b848b2f Compare March 9, 2023 09:24
@alexandre-daubois alexandre-daubois force-pushed the attributes-overview-6.3 branch from b848b2f to 095824b Compare March 9, 2023 10:21
@@ -27,11 +28,13 @@ Contracts
Dependency Injection
~~~~~~~~~~~~~~~~~~~~

* :class:`Symfony\\Component\\DependencyInjection\\Attribute\\AsAlias`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great to have an example here in a follow up PR, where we can link to

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes definitely! I plan to write some doc in the next days for missing attributes 👍

@OskarStark
Copy link
Contributor

Thank you @alexandre-daubois.

@OskarStark OskarStark merged commit 5252da2 into symfony:6.3 Mar 9, 2023
@alexandre-daubois alexandre-daubois deleted the attributes-overview-6.3 branch March 9, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants