Skip to content

[Attributes] Add attributes overview #18003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

alexandre-daubois
Copy link
Member

Fixes #17981. Once merged, I'll full-fill the page for 6.2 and 6.3 👍

@carsonbot carsonbot added this to the 5.4 milestone Mar 5, 2023
@OskarStark
Copy link
Contributor

I like this overview a lot 😎

cc @fabpot

@ker0x
Copy link
Contributor

ker0x commented Mar 5, 2023

Thanks for the PR 👍!

I made some suggestions for missing attributes with the refs to add!

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@alexandre-daubois alexandre-daubois force-pushed the attributes-reference branch 2 times, most recently from 562c8ff to f627de9 Compare March 5, 2023 12:33
@alexandre-daubois
Copy link
Member Author

Thank for the review @wouterj, that's updated 🙂

@alamirault
Copy link
Contributor

alamirault commented Mar 5, 2023

Thanks a lot for this work, this help to discover symfony features in one page.

(I did not find any forgotten property from codebase, good work !)

@OskarStark
Copy link
Contributor

As always, great addition for the Symfony documentation. Mayny thanks ❤️

@OskarStark OskarStark merged commit 287a933 into symfony:5.4 Mar 7, 2023
@OskarStark
Copy link
Contributor

OskarStark commented Mar 7, 2023

We would love to see the follow up PRs against 6.2 and 6.3 👍

@alexandre-daubois alexandre-daubois deleted the attributes-reference branch March 7, 2023 06:31
OskarStark added a commit that referenced this pull request Mar 9, 2023
…daubois)

This PR was merged into the 6.2 branch.

Discussion
----------

[Attributes] Add attributes overview for 6.2

Waiting upmerge of #18003, but here is the 6.2 followup 👍 It seems there will be some conflicts during upmerge. I'm keeping an eye on this and will update this PR accordingly

I'm on 6.3 as well!

Commits
-------

f25d340 [Attributes] Add attributes overview for 6.2
OskarStark added a commit that referenced this pull request Mar 9, 2023
…daubois)

This PR was merged into the 6.3 branch.

Discussion
----------

[Attributes] Add attributes overview for 6.3

Followup of #18003 and and waiting merge of #18014

Again, I'm keeping an eye on upmerge and will rebase accordingly 🙂

Commits
-------

095824b [Attributes] Add attributes overview for 6.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants