Skip to content

Enable argument_variable_must_match_type doctor-rst rule #17751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .doctor-rst.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
rules:
american_english: ~
argument_variable_must_match_type:
arguments:
- { type: 'ContainerBuilder', name: 'containerBuilder' }
- { type: 'ContainerConfigurator', name: 'containerConfigurator' }
avoid_repetetive_words: ~
blank_line_after_anchor: ~
blank_line_after_directive: ~
Expand Down Expand Up @@ -96,6 +100,5 @@ whitelist:
- '.. versionadded:: 3.6' # MonologBundle
- '// bin/console'
- 'End to End Tests (E2E)'
- '.. code-block:: php'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We fixed rule on OskarStark/doctor-rst#1240, so we can remove it and show real remaining issues 😃

- '.. _`a feature to test applications using Mercure`: https://github.com/symfony/panther#creating-isolated-browsers-to-test-apps-using-mercure-or-websocket'
- '.. End to End Tests (E2E)'
2 changes: 1 addition & 1 deletion components/uid.rst
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ configure the behavior of the factory using configuration files::

namespace Symfony\Component\DependencyInjection\Loader\Configurator;

return static function (ContainerConfigurator $configurator): void {
return static function (ContainerConfigurator $containerConfigurator): void {
$services = $configurator->services()
->defaults()
->autowire()
Expand Down
2 changes: 1 addition & 1 deletion security/entry_point.rst
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ You can configure this using the ``entry_point`` setting:
.. code-block:: php

// config/packages/security.php
use Symfony\Config\SecurityConfig;
use App\Security\SocialConnectAuthenticator;
use Symfony\Config\SecurityConfig;

return static function (SecurityConfig $security) {
$security->enableAuthenticatorManager(true);
Expand Down
2 changes: 1 addition & 1 deletion serializer.rst
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ configuration:
.. code-block:: php

// config/packages/framework.php
use Symfony\Config\FrameworkConfig;
use Symfony\Component\Serializer\Normalizer\AbstractObjectNormalizer;
use Symfony\Config\FrameworkConfig;

return static function (FrameworkConfig $framework) {
$framework->serializer()
Expand Down
2 changes: 1 addition & 1 deletion templating/global_variables.rst
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ the ``@`` character, which is the usual syntax to
.. code-block:: php

// config/packages/twig.php
use Symfony\Config\TwigConfig;
use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
use Symfony\Config\TwigConfig;

return static function (TwigConfig $twig) {
// ...
Expand Down