Enable argument_variable_must_match_type doctor-rst rule
#17751
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
commented
Jan 15, 2023
| @@ -96,6 +100,5 @@ whitelist: | |||
| - '.. versionadded:: 3.6' # MonologBundle | |||
| - '// bin/console' | |||
| - 'End to End Tests (E2E)' | |||
| - '.. code-block:: php' | |||
There was a problem hiding this comment.
We fixed rule on OskarStark/doctor-rst#1240, so we can remove it and show real remaining issues 😃
OskarStark
approved these changes
Jan 16, 2023
OskarStark
changed the title
argument_variable_must_match_type doctor-rst ruleargument_variable_must_match_type doctor-rst rule
|
Thank you @alamirault. |
OskarStark
added a commit
that referenced
this pull request
Jan 16, 2023
…le (alamirault) This PR was merged into the 5.4 branch. Discussion ---------- Enable `argument_variable_must_match_type` doctor-rst rule Commits ------- 5ea3a82 Enable argument_variable_must_match_type doctor-rst rule
|
I merged this PR, and upmerged it to 6.3. I close it manually, as GitHub didn't do it... 🤔 |
alamirault
deleted the
feature/doctor-argument-variable-must-match-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.