[Mailer] update mailer testing documentation #17727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jan 13, 2023
| @@ -1534,21 +1534,21 @@ Write a Functional Test | |||
| ~~~~~~~~~~~~~~~~~~~~~~~ | |||
|
|
|||
| To functionally test that an email was sent, and even assert the email content or headers, | |||
| you can use the built in assertions:: | |||
| you can use the built in assertions provided by :class:`Symfony\\Bundle\\FrameworkBundle\\Test\\MailerAssertionsTrait`. | |||
There was a problem hiding this comment.
Suggested change
| you can use the built in assertions provided by :class:`Symfony\\Bundle\\FrameworkBundle\\Test\\MailerAssertionsTrait`. | |
| you can use the built in assertions provided by the | |
| :class:`Symfony\\Bundle\\FrameworkBundle\\Test\\MailerAssertionsTrait`. |
| you can use the built in assertions:: | ||
| you can use the built in assertions provided by :class:`Symfony\\Bundle\\FrameworkBundle\\Test\\MailerAssertionsTrait`. | ||
|
|
||
| See :ref:`testing documentation <mailer-assertions>` for the list of available assertions.:: |
There was a problem hiding this comment.
Suggested change
| See :ref:`testing documentation <mailer-assertions>` for the list of available assertions.:: | |
| See :ref:`testing documentation <mailer-assertions>` for the list of available assertions:: |
|
Thanks Matthieu ... and thanks Oskar for the review (I did your changes and some minor rewords while merging). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparable as #17719 to make MailerAssertionsTrait more visible
And minor update for example