[Notifier] add notification assertion in notifier doc #17719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jan 12, 2023
notifier.rst
Outdated
| which provide useful methods for testing your Notifier implementation. | ||
| You can benefit from this class by using it directly or extending :class:`Symfony\\Bundle\\FrameworkBundle\\Test\\KernelTestCase`. | ||
|
|
||
| See :ref:`testing documentation <notifier-assertions>` for list of availables assertions. |
There was a problem hiding this comment.
Suggested change
| See :ref:`testing documentation <notifier-assertions>` for list of availables assertions. | |
| See :ref:`testing documentation <notifier-assertions>` for the list of available assertions. |
notifier.rst
Outdated
| Testing Notifier | ||
| ---------------- | ||
|
|
||
| With FrameworkBundle Symfony provide a :class:`Symfony\\Bundle\\FrameworkBundle\\Test\\NotificationAssertionsTrait` |
There was a problem hiding this comment.
Suggested change
| With FrameworkBundle Symfony provide a :class:`Symfony\\Bundle\\FrameworkBundle\\Test\\NotificationAssertionsTrait` | |
| Symfony provides a :class:`Symfony\\Bundle\\FrameworkBundle\\Test\\NotificationAssertionsTrait` |
notifier.rst
Outdated
|
|
||
| With FrameworkBundle Symfony provide a :class:`Symfony\\Bundle\\FrameworkBundle\\Test\\NotificationAssertionsTrait` | ||
| which provide useful methods for testing your Notifier implementation. | ||
| You can benefit from this class by using it directly or extending :class:`Symfony\\Bundle\\FrameworkBundle\\Test\\KernelTestCase`. |
There was a problem hiding this comment.
Suggested change
| You can benefit from this class by using it directly or extending :class:`Symfony\\Bundle\\FrameworkBundle\\Test\\KernelTestCase`. | |
| You can benefit from this class by using it directly or extending the :class:`Symfony\\Bundle\\FrameworkBundle\\Test\\KernelTestCase`. |
OskarStark
reviewed
Jan 12, 2023
notifier.rst
Outdated
|
|
||
| .. versionadded:: 6.2 | ||
|
|
||
| The Notifier assertions were introduced in Symfony 6.2. |
There was a problem hiding this comment.
Suggested change
| The Notifier assertions were introduced in Symfony 6.2. | |
| The :class:`Symfony\\Bundle\\FrameworkBundle\\Test\\NotificationAssertionsTrait` was introduced in Symfony 6.2. |
|
Thanks Oskar Stark for review 😃 |
OskarStark
approved these changes
Jan 12, 2023
OskarStark
force-pushed
the
notifier/link-testing-notifier
branch
from
e670373 to
8583932
Compare
|
Thank you @MrYamous. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading testing documentation I came across some assertions for notifications. I think it can be useful to talk about this directly in Notifier documentation too, WDYT ?