Skip to content

[DependencyInjection] Document service tags being moved when decorating #17273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024
Merged

[DependencyInjection] Document service tags being moved when decorating #17273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion service_container/service_decoration.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,9 @@
The ``#[AsDecorator]`` attribute was introduced in Symfony 6.1.

The ``decorates`` option tells the container that the ``App\DecoratingMailer``
service replaces the ``App\Mailer`` service. If you're using the
service replaces the ``App\Mailer`` service.

Check failure on line 131 in service_container/service_decoration.rst

View workflow job for this annotation

GitHub Actions / Lint (DOCtor-RST) 

Please remove trailing whitespace
:ref:`Service tags<How to Work with Service Tags> are moved as well.

Check failure on line 132 in service_container/service_decoration.rst

View workflow job for this annotation

GitHub Actions / Lint (DOCtor-RST) 

Please remove trailing whitespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand well symfony codebase, not all tags are kept

https://github.com/symfony/symfony/blob/7de25db56093a53b0b2d85f96d716ff6e9bf7147/src/Symfony/Component/DependencyInjection/Compiler/DecoratorServicePass.php#L49-L52

https://github.com/symfony/symfony/blob/7de25db56093a53b0b2d85f96d716ff6e9bf7147/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L739-L748

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documenting all that is a bit too much for me I am afraid . I rarely use github for collaboration, how do I invite others to help?

If you're using the
:ref:`default services.yaml configuration <service-container-services-load-example>`,
the decorated service is automatically injected when the constructor of the
decorating service has one argument type-hinted with the decorated service class.
Expand Down
Loading