[DependencyInjection] Document service tags being moved when decorating #17273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chx
changed the title
carsonbot
changed the title
alamirault
reviewed
Oct 17, 2023
| @@ -131,7 +131,9 @@ but keeps a reference of the old one as ``.inner``: | |||
| The ``#[AsDecorator]`` attribute was introduced in Symfony 6.1. | |||
|
|
|||
| The ``decorates`` option tells the container that the ``App\DecoratingMailer`` | |||
| service replaces the ``App\Mailer`` service. If you're using the | |||
| service replaces the ``App\Mailer`` service. | |||
| :ref:`Service tags<How to Work with Service Tags> are moved as well. | |||
There was a problem hiding this comment.
If I understand well symfony codebase, not all tags are kept
There was a problem hiding this comment.
Documenting all that is a bit too much for me I am afraid . I rarely use github for collaboration, how do I invite others to help?
Note service tags.
javiereguiluz
force-pushed
the
patch-1
branch
from
4236e61 to
776f7e8
Compare
|
Thanks @chx and we're very sorry that it took us so long to process this contribution. @alamirault I took your references and, while merging, I added the list of the tags kept when decorating services. Thanks! |
|
Thank you @javiereguiluz I checked your note, and it's look good to me ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note service tags.