Skip to content

[Doctrine] MakerBundle 1.3 is too old to reference #17022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2022
Merged

[Doctrine] MakerBundle 1.3 is too old to reference #17022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .doctor-rst.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,7 @@ whitelist:
- '.. versionadded:: 2.4.0' # SwiftMailer
- '.. versionadded:: 1.30' # Twig
- '.. versionadded:: 1.35' # Twig
- '.. versionadded:: 1.2' # MakerBundle
- '.. versionadded:: 1.11' # MakerBundle
- '.. versionadded:: 1.3' # MakerBundle
- '.. versionadded:: 1.8' # MakerBundle
- '.. versionadded:: 1.11' # Messenger (Middleware / DoctrineBundle)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 1.8 is not needed (not referenced in the docs)

- '.. versionadded:: 1.18' # Flex in setup/upgrade_minor.rst
- '.. versionadded:: 1.0.0' # Encore
- '0 => 123' # assertion for var_dumper - components/var_dumper.rst
Expand Down
6 changes: 1 addition & 5 deletions controller.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ and ``redirect()`` methods::

// redirects to a route and maintains the original query string parameters
return $this->redirectToRoute('blog_show', $request->query->all());

// redirects to the current route (e.g. for Post/Redirect/Get pattern):
return $this->redirectToRoute($request->attributes->get('_route'));

Expand Down Expand Up @@ -315,10 +315,6 @@ use:
created: templates/product/new.html.twig
created: templates/product/show.html.twig

.. versionadded:: 1.2

The ``make:crud`` command was introduced in MakerBundle 1.2.

.. index::
single: Controller; Managing errors
single: Controller; 404 pages
Expand Down
5 changes: 0 additions & 5 deletions doctrine.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,6 @@ need. The command will ask you some questions - answer them like done below:
>
(press enter again to finish)

.. versionadded:: 1.3

The interactive behavior of the ``make:entity`` command was introduced
in MakerBundle 1.3.

Whoa! You now have a new ``src/Entity/Product.php`` file::

// src/Entity/Product.php
Expand Down