[Doctrine] MakerBundle 1.3 is too old to reference #17022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/ Cheers! Carsonbot |
jrushlow
force-pushed
the
remove-1.3
branch
2 times, most recently
from
97e4362 to
7dcac6a
Compare
jrushlow
commented
Jul 20, 2022
| - '.. versionadded:: 1.2' # MakerBundle | ||
| - '.. versionadded:: 1.11' # MakerBundle | ||
| - '.. versionadded:: 1.3' # MakerBundle | ||
| - '.. versionadded:: 1.8' # MakerBundle | ||
| - '.. versionadded:: 1.11' # Messenger (Middleware / DoctrineBundle) |
There was a problem hiding this comment.
Version 1.8 is not needed (not referenced in the docs)
|
Jesse, thanks for this contribution. However, it was sent to |
OskarStark
approved these changes
Jul 22, 2022
|
@javiereguiluz should we target 4.4 here or do we need 5.4 ? |
|
Let's merge it in 5.4 😉 Thanks Jesse for yet another nice contribution! |
javiereguiluz
force-pushed
the
remove-1.3
branch
from
38aac2e to
424ad98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MakerBundle 1.2/1.3 were released back in 2018. We're at
v1.44.0now. I don't think we need to reference this anymore.