Skip to content

[CI] Don't use special repository for symfony-tools/docs-builder #15284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2021

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Apr 23, 2021

When symfony-tools/docs-builder is registered on packagist, we can remove the composer.json and composer.lock. But Im not sure we want to do that because we dont want to "live on the edge".

Blocked by symfony-tools/docs-builder#99

@Nyholm Nyholm requested a review from OskarStark as a code owner April 23, 2021 15:11
@javiereguiluz javiereguiluz changed the title [WIP][CI] Dont use special reposiroty for symfony-tools/docs-builder [WIP][CI] Don't use special repository for symfony-tools/docs-builder Apr 23, 2021
@Nyholm Nyholm force-pushed the ci-symfony-tools-docs-builder branch from 97cce7e to 23c137b Compare April 24, 2021 18:25
@Nyholm Nyholm changed the base branch from 5.x to 4.4 April 24, 2021 18:25
@Nyholm Nyholm force-pushed the ci-symfony-tools-docs-builder branch from 23c137b to 77e8c90 Compare April 24, 2021 18:26
@javiereguiluz
Copy link
Member

Does this proposal still need some work before considering it finished? Thanks!

@Nyholm
Copy link
Member Author

Nyholm commented Apr 30, 2021

We are waiting for this PR to be merged: symfony-tools/docs-builder#99

@javiereguiluz javiereguiluz changed the title [WIP][CI] Don't use special repository for symfony-tools/docs-builder [CI] Don't use special repository for symfony-tools/docs-builder May 18, 2021
@javiereguiluz javiereguiluz force-pushed the ci-symfony-tools-docs-builder branch from 77e8c90 to a044021 Compare May 21, 2021 10:41
@javiereguiluz
Copy link
Member

Merged! Thanks.

@javiereguiluz javiereguiluz merged commit 7585026 into symfony:4.4 May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants