Skip to content

Update composer package organization #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2021
Merged

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Apr 23, 2021

This will sync up with symfony-tools/code-block-checker#35.

It will allow two things:

  1. We can properly use a dependency in Use symfony-tools/docs-builder from packagist code-block-checker#39
  2. We could (if we wanted to) remove the composer.json in [CI] Don't use special repository for symfony-tools/docs-builder symfony/symfony-docs#15284

When this PR is merged, I'll add the package on packagist.

@wouterj
Copy link
Contributor

wouterj commented Apr 24, 2021

Hmm, I'm not so sure about this. Is there any advantages to publishing this on packagist, rather than using the current repositories option?

Not publishing on Packagist communicates very clearly that this is an open source internal tool that is not meant to be used outside Symfony's CI/CD.

Copy link
Contributor

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your argument makes sense to me too. However, I think Fabien is in favor of this change... and... if we have a clear warning on this library's readme (which we already do), and people still use it, then they know they are "on their own". So it's a 👍 from me

@Nyholm Nyholm changed the title Update compare package organization Update composer package organization Apr 24, 2021
Copy link
Collaborator

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Wouter ... but I'm voting +1 to try to move this forward.

We can always remove this project from Packagist and/or GitHub in the future if we want. Thanks!

@Nyholm Nyholm merged commit a90dd3b into symfony-tools:main May 16, 2021
@Nyholm Nyholm deleted the package-name branch May 16, 2021 12:33
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request May 21, 2021
…-builder (Nyholm)

This PR was merged into the 4.4 branch.

Discussion
----------

[CI] Don't use special repository for symfony-tools/docs-builder

When `symfony-tools/docs-builder` is registered on packagist, we can remove the composer.json and composer.lock. But Im not sure we want to do that because we dont want to "live on the edge".

Blocked by symfony-tools/docs-builder#99

Commits
-------

a044021 [CI] Dont use special reposiroty for symfony-tools/docs-builder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants