Update best_practices.rst #14850
Merged
Update best_practices.rst #14850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
added a commit
to symfony-tools/carsonbot
that referenced
this pull request
Jan 19, 2021
This PR was merged into the master branch. Discussion ---------- Disable suggesting reviewers in docs repository I shortly discussed this with the doc team, and I think this feature is not applicable to the docs repo: * It's very common for us to not respond to a PR within 20 hours * Many documents are created by us, the community mostly fixes small stuff. Also, 1 document contains many features, editing a line somewhere in the document doesn't indicate you're the expert for other features in the document. E.g. in symfony/symfony-docs#14850, the pinged user modified the example README: symfony/symfony-docs@6e8d393 Commits ------- 7c9391d Disable suggesting reviewers in docs repository
|
Thanks for this contribution. I wasn't sure about this, so I checked the code and I found this: Apparently, we don't check if the class is an instance of |
|
I don't think it's enforced, but I do think it's a best practice. I've been looking at various widely used packages to get familiar with bundles and they all seem to extend |
javiereguiluz
added
Status: Reviewed
and removed
Status: Needs Review
Waiting feedback
labels
|
I've asked around but nobody gives me a clear answer ... so let's merge this. Thanks Boris! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that all bundles extend
Symfony\Component\HttpKernel\Bundle\Bundlewhich should be included in the requirements.Also as
Symfony\Component\HttpKernel\Bundle\Bundlealready hasfinal public function getName()it makes sense to remove the suggestion that this method should be implemented.