Skip to content

Commit e460402

Browse files
committed
minor #14850 Update best_practices.rst (botris)
This PR was merged into the 5.2 branch. Discussion ---------- Update best_practices.rst It seems that all bundles extend `Symfony\Component\HttpKernel\Bundle\Bundle` which should be included in the requirements. Also as `Symfony\Component\HttpKernel\Bundle\Bundle` already has `final public function getName()` it makes sense to remove the suggestion that this method should be implemented. Commits ------- d75a175 Update best_practices.rst
2 parents 358e141 + d75a175 commit e460402

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

bundles/best_practices.rst

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ namespace short name, which must end with ``Bundle``.
2525
A namespace becomes a bundle as soon as you add a bundle class to it. The
2626
bundle class name must follow these rules:
2727

28+
* Extend Symfony\Component\HttpKernel\Bundle\Bundle
2829
* Use only alphanumeric characters and underscores;
2930
* Use a StudlyCaps name (i.e. camelCase with an uppercase first letter);
3031
* Use a descriptive and short name (no more than two words);
@@ -41,9 +42,6 @@ Namespace Bundle Class Name
4142
``Acme\BlogBundle`` AcmeBlogBundle
4243
========================== ==================
4344

44-
By convention, the ``getName()`` method of the bundle class should return the
45-
class name.
46-
4745
.. note::
4846

4947
If you share your bundle publicly, you must use the bundle class name as

0 commit comments

Comments
 (0)