Skip to content

Update performance.rst #14489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions performance.rst
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,8 @@ deployment process too):

.. _profiling-applications:

Profiling Applications
----------------------
Profiling Applications and Stopwatch
Copy link

@Matts Matts Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ThomasLandauer

Shouldn't this be the following?

Suggested change
Profiling Applications and Stopwatch
Profiling Applications with Stopwatch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using the Stopwatch to measure how long a Console Command is taking to run. That's it. I wouldn't call that "profiling" - would you? So the message I'm trying to get across with the word "and" is: "It is a stopwatch; you can use it for profiling; but you can also just use it as a, well, stopwatch."
But I must admit that this message certainly doesn't get across fully ;-)

------------------------------------

`Blackfire`_ is the best tool to profile and optimize performance of Symfony
applications during development, test and production. It's a commercial service,
Expand All @@ -223,8 +223,8 @@ Symfony provides a basic performance profiler in the development
of the :ref:`web debug toolbar <web-debug-toolbar>` to see how much time Symfony
spent on tasks such as making database queries and rendering templates.

Custom Profiling
~~~~~~~~~~~~~~~~
Custom Profiling with the Symfony Stopwatch
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

You can measure the execution time and memory consumption of your own code and
display the result in the Symfony profiler thanks to the `Stopwatch component`_.
Expand Down