Skip to content

Update performance.rst #14489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ThomasLandauer
Copy link
Contributor

@ThomasLandauer ThomasLandauer commented Oct 26, 2020

Promoting the term "Stopwatch" to improve Google findability, and also https://symfony.com/doc/4.4/index.html
See #14476

Promoting the term "Stopwatch" to improve Google findability
@@ -211,8 +211,8 @@ deployment process too):

.. _profiling-applications:

Profiling Applications
----------------------
Profiling Applications and Stopwatch
Copy link

@Matts Matts Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ThomasLandauer

Shouldn't this be the following?

Suggested change
Profiling Applications and Stopwatch
Profiling Applications with Stopwatch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using the Stopwatch to measure how long a Console Command is taking to run. That's it. I wouldn't call that "profiling" - would you? So the message I'm trying to get across with the word "and" is: "It is a stopwatch; you can use it for profiling; but you can also just use it as a, well, stopwatch."
But I must admit that this message certainly doesn't get across fully ;-)

@javiereguiluz
Copy link
Member

Thomas, I thank your for proposing this but I'm going to close it as "won't merge". The reason is that this page already includes the "stopwatch" word tens of times. Here are some of those occurrences:

image

Thanks for understanding!

@ThomasLandauer
Copy link
Contributor Author

I have 3 counter arguments:

@ThomasLandauer
Copy link
Contributor Author

ping @javiereguiluz :-)

@javiereguiluz
Copy link
Member

See #14502.

@ThomasLandauer ThomasLandauer deleted the patch-6 branch October 30, 2020 16:52
javiereguiluz added a commit that referenced this pull request Nov 2, 2020
…ions (javiereguiluz)

This PR was merged into the 4.4 branch.

Discussion
----------

[Performance] Mention Symfony Stopwatch in some doc sections

This continues #14489 but makes less changes.

Commits
-------

f746ec1 [Performance] Mention Symfony Stowatch in some doc sections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants