Skip to content

Replace ExceptionListener uses with ErrorListener #13391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

APachecoDiSanti
Copy link
Contributor

ExceptionListener has been deprecated in version 5.0 of symfony/http-kernel:
https://github.com/symfony/http-kernel/blob/master/CHANGELOG.md
The changelog recommends using ErrorListener instead.

@javiereguiluz
Copy link
Member

These docs are very special because they belong to a special series called "Create your own framework". This is not really part of the Symfony Docs. So, I'm going to ask @wouterj and @xabbuh to see if they think we should change this. Thanks.

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say we should definitely change this. The code is broken, as the ExceptionListener no longer exists. Looking at the source code, I think both behave exactly the same. So these changes make perfect sense to me.

Thanks @APachecoDiSanti!

@wouterj wouterj added this to the 4.4 milestone Mar 23, 2020
@javiereguiluz
Copy link
Member

Thanks Agustín ... and congrats on your first Symfony Docs contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants