Skip to content

Change ExceptionListener to ErrorListener #13335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Change ExceptionListener to ErrorListener #13335

wants to merge 1 commit into from

Conversation

superbull
Copy link
Contributor

No description provided.

yceruto
yceruto reviewed Mar 13, 2020
View reviewed changes
create_framework/http_kernel_httpkernel_class.rst

``ExceptionListener`` gives you a ``FlattenException`` instance instead of the
``ErrorListener`` gives you a ``FlattenException`` instance instead of the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it gives you a FlattenException instance if it's typehined as such in your controller or if the exception argument is not typed at all, otherwise it will give you a \Throwable instance.

@javiereguiluz
Copy link
Member

@superbull thanks a lot for your contribution. Sadly, I didn't realize you contributed this and I've just merged a similar pull request (#13391). I should have merged yours instead because it's older, so I apologize. I look forward to merge other contributions from you in the future. Thanks!

@superbull
Copy link
Contributor Author

@javiereguiluz no problem. Thanks for the notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@superbull @javiereguiluz @yceruto @carsonbot