Skip to content

Clarified the two main types of exceptions thrown in HttpClient #12768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

Toflar
Copy link
Contributor

@Toflar Toflar commented Dec 5, 2019

As learned from @nicolas-grekas in symfony/symfony#34837.
I guess it's worth clarifying it a little bit :)

Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Toflar for this PR. Could you please have a look at # #13136 which has been merged recently and take it into account. Also please rebase onto 4.4, since 4.3 is not maintained anymore. Thanks!

@HeahDude HeahDude added this to the 4.4 milestone Feb 19, 2020
@Toflar Toflar requested a review from xabbuh as a code owner February 24, 2020 14:49
@Toflar Toflar changed the base branch from 4.3 to 4.4 February 24, 2020 14:49
@Toflar
Copy link
Contributor Author

Toflar commented Feb 24, 2020

Based onto 4.4 and addressed comments. I guess I don't need to rebase and force push as you're going to squash merge anyway? :)

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase - squashing PRs with merge commits takes more time for maintainers.

@Toflar Toflar force-pushed the describe-http-client-exceptions branch from 41c672a to 1e13d5f Compare February 24, 2020 15:06
@Toflar
Copy link
Contributor Author

Toflar commented Feb 24, 2020

Rebased :)

@Toflar Toflar force-pushed the describe-http-client-exceptions branch from 1e13d5f to d815202 Compare February 24, 2020 15:17
@Toflar
Copy link
Contributor Author

Toflar commented Feb 24, 2020

Sorry, messed up with the rebase. Should be fixed now 🤦‍♂

@javiereguiluz
Copy link
Member

Thanks Yanick.

@javiereguiluz javiereguiluz merged commit 117e239 into symfony:4.4 Mar 6, 2020
@Toflar Toflar deleted the describe-http-client-exceptions branch March 6, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants