-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Clarified the two main types of exceptions thrown in HttpClient #12768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarified the two main types of exceptions thrown in HttpClient #12768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based onto 4.4 and addressed comments. I guess I don't need to rebase and force push as you're going to squash merge anyway? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase - squashing PRs with merge commits takes more time for maintainers.
41c672a
to
1e13d5f
Compare
Rebased :) |
1e13d5f
to
d815202
Compare
Sorry, messed up with the rebase. Should be fixed now 🤦♂ |
Thanks Yanick. |
As learned from @nicolas-grekas in symfony/symfony#34837.
I guess it's worth clarifying it a little bit :)