Tweak the version constraints when installing 3.4 components #12347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
OskarStark
approved these changes
Sep 20, 2019
javiereguiluz
added a commit
that referenced
this pull request
Sep 23, 2019
…ents (javiereguiluz) This PR was merged into the 3.4 branch. Discussion ---------- Tweak the version constraints when installing 3.4 components This continues the idea proposed in #10971. @xabbuh could you please review if this is correct? (for example, I didn't add this to polyfill packages, is that correct to you?). Also, if this is merged, could you please verify that we should revert these changes in the other branches (4.3, 4.4 and master)? Thanks! Commits ------- cdc9e76 Tweak the version constraints when installing 3.4 components
|
@javiereguiluz Sorry for the late feedback. This looks good to me. 👍 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the idea proposed in #10971.
@xabbuh could you please review if this is correct? (for example, I didn't add this to polyfill packages, is that correct to you?).
Also, if this is merged, could you please verify that we should revert these changes in the other branches (4.3, 4.4 and master)?
Thanks!