Update the installation instructions for components #11754
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
requested changes
Jun 14, 2019
| @@ -29,7 +29,7 @@ Installation | |||
|
|
|||
| .. code-block:: terminal | |||
|
|
|||
| $ composer require --dev "symfony/phpunit-bridge:*" | |||
| $ composer require --dev "symfony/phpunit-bridge::^3.4" | |||
There was a problem hiding this comment.
No double colon here and the quotes are not needed, right?
There was a problem hiding this comment.
Quotes are needed by some shells like zsh IIRC.
There was a problem hiding this comment.
Ok, but for now we are not using quotes across the docs, maybe we should add them everywhere then
There was a problem hiding this comment.
I think so. I confirm the behavior. Quoting is what I'm doing in Twig's docs: https://twig.symfony.com/doc/2.x/installation.html
|
Closing as fixed by #12347, which was a duplicate of this pull request. 🤦♂ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #10971. My questions:
^3.4by each branch? In all of them except "current"? Should we use "dev-master" for master?