[Workflow] doc improvements #11578
Merged
[Workflow] doc improvements #11578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
May 16, 2019
| # run this command if you prefer SVG images: | ||
| # $ php dump-graph-dot.php | dot -Tsvg -o dot_graph.svg | ||
| $ php dump-graph-puml.php | java -jar plantuml.jar -p > puml_graph.png |
There was a problem hiding this comment.
this grouping is a bit confusing now, because it generates a png file, but follows a comment/description which is talking about svg 🤔
There was a problem hiding this comment.
wanted to "group" dot cli vs java
i propose a new way
| $ php bin/console workflow:dump workflow_name | dot -Tpng -o workflow_name.png | ||
| # run this command if you prefer SVG images: | ||
| # $ php bin/console workflow:dump workflow_name | dot -Tsvg -o workflow_name.svg | ||
| $ php bin/console workflow:dump workflow_name --dump-format=puml | java -jar plantuml.jar -p > workflow_name.png |
noniagriconomie
force-pushed
the
feature-workflow-doc
branch
from
5a2074b to
7e65c40
Compare
|
@OskarStark review/rework addressed |
|
Note to mergers: merge in 4.2 branch. |
Closed
noniagriconomie
commented
May 16, 2019
OskarStark
force-pushed
the
feature-workflow-doc
branch
from
7e65c40 to
d6b8d18
Compare
|
Thank you Antoine, I merged it in |
OskarStark
added a commit
that referenced
this pull request
May 17, 2019
This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes #11578). Discussion ---------- [Workflow] doc improvements Hi, Here are some workflow doc improvements: - keep as much as possible in synch the subject, places and transition in the related docs - change "travis" in favor of "test" (travis may not be known) + update image - move transition blocker via listener part into the right sub part + rewrite it Thanks Commits ------- d6b8d18 Workflow doc
wouterj
added a commit
that referenced
this pull request
Aug 12, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [4.3] Update workflow config Rescued some really bad git stuff from me while merging: #11580 Original description: > Hi, > > This draft PR follows this one > https://github.com/symfony/symfony-docs/pull/11492/files (config for 3.X version) > but for new version, mostly 4.3 > > I checked this PR also > symfony/symfony#30890, @lyrixx review appreciated please > > Maybe to merge after merging #11578, and with a rebase ? > > -------------------- > > Draft for now > > - Closes #11229 > > this one can be closed also: > > - Closes #9475 > - Closes #10197 Commits ------- fdc221b Minor XML improvement a640d14 [Workflow] config doc 7bb2041 Fix indent f65f1bc Review cf3a32c Doc config metadata 34e7cc5 [Workflow] config doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here are some workflow doc improvements:
Thanks