-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Added a guide for Symfony Docs maintainers #11161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start!
# make sure that your local branch is updated | ||
$ git checkout 3.4 | ||
$ git fetch upstream | ||
$ git merge upstream/3.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed, gh takes care of this
$ git add components/phpunit_bridge.rst | ||
$ git commit -a | ||
$ git push origin | ||
$ git push upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's during a merge with gh
, just re-run gh
. It knows it stopped in a merge conflict and continues finishing it's merge proces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such an excellent guide @javiereguiluz! I only have one minor remark for now.
I always read this article but will do in detail again, later today 👍🏻 |
@javiereguiluz why is this file in the
|
@OskarStark the article has been created in |
Thank you all for the reviews. I've made most (but not all) of the requested changes ... and I've merged it to move forward. We can fix and tweak further things later. |
This is for maintainers of this repo, so it doesn't have interest for normal Symfony users.
@OskarStark as the newest doc maintainer, this guide is mainly for you. When you have some time, please read it and report any problem or confusing explanation.
@xabbuh @wouterj @HeahDude as expert maintainers, please check if I missed something important about merging PRs. Two comments: