Updated link to Event Listeners page #10195
Conversation
Not sure if I got it right (preview isn't showing it) - the page I wanted to link to is https://symfony.com/doc/current/bundles/DoctrineBundle/entity-listeners.html
| It is a lifecycle listener class used for an entity. You can read | ||
| about it in `the Doctrine Documentation`_. | ||
| It is a lifecycle listener class used for an entity. See | ||
| :doc:`Entity Listeners </entity-listeners> |
There was a problem hiding this comment.
Since the documentation for DoctrineBundle is built independently we cannot use the doc role here. I would revert the changes in this paragraph...
| @@ -269,4 +270,3 @@ to the tag like so: | |||
| definitions which are described :doc:`in their own article </service_container/lazy_services>` | |||
|
|
|||
| .. _`The Event System`: http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/events.html | |||
| .. _`the Doctrine Documentation`: http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/events.html#entity-listeners | |||
There was a problem hiding this comment.
... and just change the target here to https://symfony.com/doc/current/bundles/DoctrineBundle/entity-listeners.html
There was a problem hiding this comment.
OK, done :-)
|
Thank you @ThomasLandauer. |
…bbuh) This PR was merged into the 2.8 branch. Discussion ---------- Updated link to Event Listeners page Not sure if I got it right (preview isn't showing it) - the page I wanted to link to is https://symfony.com/doc/current/bundles/DoctrineBundle/entity-listeners.html <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 58647a0 fix the markup 567616f Changing to absolute url, as requested f521534 Updated link to Event Listeners page
|
@xabbuh Reading this page again, I'm wondering: Shouldn't the entity listeners be presented as the preferred way of doing it? So since entity listeners have been around for some time, what's the use case for event listeners and subscribers at all anymore? And what about merging https://symfony.com/doc/current/bundles/DoctrineBundle/entity-listeners.html and http://symfony.com/doc/current/doctrine/event_listeners_subscribers.html#creating-the-listener-class ? |
|
Would you like to open a new issue? Comments are likely to get lost in a merged PR. |
Not sure if I got it right (preview isn't showing it) - the page I wanted to link to is https://symfony.com/doc/current/bundles/DoctrineBundle/entity-listeners.html